{ Dev Farm }

Web & Windows Development

Bugfix PRs

Home Forum Wp Gpx Maps Support Bugfix PRs

Stai visualizzando 2 post - dal 1 a 2 (di 2 totali)
  • Autore
    Post
  • #95807 Rispondi
    Martin Welte
    Ospite

    Hey @bastianonm
    I wanted to make PRs but couldn’t find a git repo. only svn :/ Would have to set it up just for this.
    so i am doing this here:

    /wp-gpx-maps-admin.php: line 251 (end of file):

    – original: <!– The First Div (for body) ends in the respective file for the corresponding tab –>
    – fix: remove html comment from end of php admin file
    – reason:
    If you use <!— in a php file it will generate output, which is in this case fatal. It will kill all json outputs made by wordpress. (aka Rest calls, auto-save features, medialibary calls,…).
    If you want to keep the comment use // within the php tags

    /wp-gpx-maps-admin.php: line 178:

    – original: $tab = $_GET[‘tab’];
    – fix: $tab = isset($_GET[“tab”]) ? sanitize_text_field($_GET[“tab”]) : “”;
    – reason: saftey, don’t trust user input, ever..

    keep up the good work https://devfarm.it/wp-content/plugins/wp-monalisa/icons/wpml_good.gif

    #95917 Rispondi
    max
    Amministratore del forum

    Thanks!

Stai visualizzando 2 post - dal 1 a 2 (di 2 totali)
Rispondi a: Bugfix PRs

You can use BBCodes to format your content.
Your account can't use Advanced BBCodes, they will be stripped before saving.

Le tue informazioni:




:bye:  :good:  :negative:  :scratch:  :wacko:  :yahoo:  B-) 
more...
 

Non è possibile lasciare nuovi commenti.